-
Notifications
You must be signed in to change notification settings - Fork 664
Bump rust-toolchain to rust 1.88 #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If we're going to maintain a lower MSRV than we use for development, I'd like to ensure we have CI which runs with that version. |
|
I personally don't see a particularly strong motivation to not bump for bindings and its dependents as well. |
1459374 to
846897a
Compare
846897a to
aa5a898
Compare
4e23857 to
69d916f
Compare
|
I've reviewed @coolreader18's changes. They look good. |
cf83468 to
e5f0adc
Compare
|
@cloutiertyler This is ready for review. Private companion is https://github.com/clockworklabs/SpacetimeDBPrivate/pull/1847. |
|
@Centril I don't believe this is a priority |
|
@cloutiertyler This is a requirement for V8 modules because the |
cloutiertyler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Centril Thanks for the clarification!
c455c9f to
0dc5011
Compare
13673bd to
04dc539
Compare
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Description of Changes
This bumps our rust-toolchain in the file to 1.88,
but doesn't bump the MSRV of the bindings crate and its dependents. We could, if we wanted to, but we don't really have an MSRV policy in placeand bumps the rust-version in Cargo.toml as well. This is necessary because thev8crate has a fairly aggressive MSRV and I'd like to not fall too far behind from their latest version, since that's also the version of V8 itself.This is a precursor to #2839.
API and ABI breaking changes
None
Expected complexity level and risk
2 - rust version changes can cause problems but it's very rare
Testing
Do we want to run any manual testing?