Skip to content

Conversation

@coolreader18
Copy link
Collaborator

@coolreader18 coolreader18 commented May 16, 2025

Description of Changes

This bumps our rust-toolchain in the file to 1.88, but doesn't bump the MSRV of the bindings crate and its dependents. We could, if we wanted to, but we don't really have an MSRV policy in place and bumps the rust-version in Cargo.toml as well. This is necessary because the v8 crate has a fairly aggressive MSRV and I'd like to not fall too far behind from their latest version, since that's also the version of V8 itself.

This is a precursor to #2839.

API and ABI breaking changes

None

Expected complexity level and risk

2 - rust version changes can cause problems but it's very rare

Testing

Do we want to run any manual testing?

@gefjon
Copy link
Contributor

gefjon commented May 19, 2025

If we're going to maintain a lower MSRV than we use for development, I'd like to ensure we have CI which runs with that version.

@bfops bfops added the release-any To be landed in any release window label May 19, 2025
@Centril
Copy link
Contributor

Centril commented May 19, 2025

I personally don't see a particularly strong motivation to not bump for bindings and its dependents as well.

@Centril Centril force-pushed the noa/bump-rust-1.87 branch from 846897a to aa5a898 Compare July 4, 2025 12:57
@Centril Centril changed the title Bump rust-toolchain to rust 1.87 Bump rust-toolchain to rust 1.88 Jul 4, 2025
@Centril Centril force-pushed the noa/bump-rust-1.87 branch 2 times, most recently from 4e23857 to 69d916f Compare July 4, 2025 13:24
@Centril
Copy link
Contributor

Centril commented Jul 4, 2025

I've reviewed @coolreader18's changes. They look good.
I've then changed the Rust version to 1.88 so that we also get let_chains and cargo automatic cache cleaning.
Finally, I've rebased this PR atop of master.
It should be ready for review now.
I'll investigate and fix the internal tests meanwhile.

@Centril Centril force-pushed the noa/bump-rust-1.87 branch 3 times, most recently from cf83468 to e5f0adc Compare July 8, 2025 09:21
@Centril
Copy link
Contributor

Centril commented Jul 8, 2025

@cloutiertyler This is ready for review. Private companion is https://github.com/clockworklabs/SpacetimeDBPrivate/pull/1847.

@cloutiertyler
Copy link
Contributor

@Centril I don't believe this is a priority

@Centril
Copy link
Contributor

Centril commented Jul 8, 2025

@cloutiertyler This is a requirement for V8 modules because the v8 dependency uses edition 2024 which does not exist on our version of Rust.

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Centril Thanks for the clarification!

@Centril Centril force-pushed the noa/bump-rust-1.87 branch 4 times, most recently from c455c9f to 0dc5011 Compare July 14, 2025 17:56
@Centril Centril force-pushed the noa/bump-rust-1.87 branch from 13673bd to 04dc539 Compare July 15, 2025 17:13
@Centril Centril enabled auto-merge July 15, 2025 17:13
@Centril Centril added this pull request to the merge queue Jul 15, 2025
Merged via the queue into master with commit 742303c Jul 15, 2025
18 of 19 checks passed
mamcx pushed a commit that referenced this pull request Aug 26, 2025
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants