Skip to content

Fix TypeScript imports codegen #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsdt merged 3 commits into from
May 21, 2025
Merged

Fix TypeScript imports codegen #2747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feded36
codegen: add type modifier to mixed typescript imports
toqueteos May 16, 2025
ddefc3e
Update snap
jsdt May 21, 2025
54774b7
Merge branch 'master' into patch-1
jsdt May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions crates/codegen/src/typescript.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ impl Lang for TypeScript {

writeln!(
out,
"import {{ EventContext, Reducer, RemoteReducers, RemoteTables }} from \".\";"
"import {{ type EventContext, type Reducer, RemoteReducers, RemoteTables }} from \".\";"
);

let table_name = table.name.deref();
Expand Down Expand Up @@ -636,16 +636,16 @@ fn print_spacetimedb_imports(out: &mut Indenter) {
"DbConnectionBuilder",
"TableCache",
"BinaryWriter",
"CallReducerFlags",
"EventContextInterface",
"ReducerEventContextInterface",
"SubscriptionEventContextInterface",
"ErrorContextInterface",
"type CallReducerFlags",
"type EventContextInterface",
"type ReducerEventContextInterface",
"type SubscriptionEventContextInterface",
"type ErrorContextInterface",
"SubscriptionBuilderImpl",
"BinaryReader",
"DbConnectionImpl",
"DbContext",
"Event",
"type DbContext",
"type Event",
"deepEqual",
];
types.sort();
Expand Down
Loading
Loading