-
Notifications
You must be signed in to change notification settings - Fork 664
Cache with_label_values more & don't do metrics while holding lock
#2734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
commented
May 14, 2025
with_label_values where possible & don't do metrics while holding lockwith_label_values more & don't do metrics while holding lock
gefjon
reviewed
May 14, 2025
17ec5d4 to
82f9ff5
Compare
gefjon
approved these changes
May 20, 2025
cloutiertyler
approved these changes
May 21, 2025
Contributor
cloutiertyler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments.
864ab59 to
87d0a73
Compare
6b90c08 to
9df55dd
Compare
9df55dd to
b307d8c
Compare
cloutiertyler
pushed a commit
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Two things happen here that work together to improve performance:
with_label_valuesare cached to the extent possible.Changes to
traits.rsare:TxMetricsand sometimes also the reducer name (String) from theExecutionContext.TxDatanow exposes which tables were affected.Closes #1099 which was the first attempt at not reporting while holding the lock. The PR has since bitrotted.
API and ABI breaking changes
None
Expected complexity level and risk
3, most of the complication is where datastore transactionality is touched.
Testing
Should be covered by existing tests.