commitlog: Include latest commit offset in segment metadata #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
reviewed
May 15, 2025
Contributor
Shubham8287
left a comment
Shubham8287
left a comment
There was a problem hiding this comment.
It looks correct, but I am missing intention behind this patch?
Is it to serve accepted_offset on fetch-api?
Contributor
Author
|
I needed to know the head commit's range from only the commitlog. Since the information is already there, it seemed convenient to expose it. |
Contributor
Author
|
The motivation is more like determining an accepted offset for bootstrapping. |
Shubham8287
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The segment metadata, obtained e.g. via
committed_meta, will now include the start offset of the last commit read from the segment.API and ABI breaking changes
No
Expected complexity level and risk
1
Testing