Skip to content

Conversation

@joshua-spacetime
Copy link
Collaborator

Description of Changes

Do not evaluate subscriptions that are statically determined to return empty result sets.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

Added a test that asserts on execution metrics.

@joshua-spacetime joshua-spacetime requested a review from mamcx May 13, 2025 21:47
@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/plan-is-empty branch from 3b1bb72 to 017fd24 Compare May 13, 2025 22:32
@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/plan-is-empty branch from 017fd24 to 77809e3 Compare May 13, 2025 22:32
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stealing this review from @mamcx. Some minor requests that would be good to address before merging, but otherwise this looks good.

joshua-spacetime and others added 3 commits May 14, 2025 06:44
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
@joshua-spacetime joshua-spacetime added this pull request to the merge queue May 14, 2025
Merged via the queue into master with commit 6eef698 May 14, 2025
20 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/perf/plan-is-empty branch May 14, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants