Use spawn_blocking for the fallback commit in identity_dis/connected #2730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
approved these changes
May 14, 2025
coolreader18
changed the title
coolreader18
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
with_auto_committakes a lock, which we shouldn't be doing in a tokio task. The second commit uses the utility wrapper in more places aroundcore, which makes the callsites clearer; based off a similar internal function in tokio (pub(crate) tokio::fs::asyncify).Expected complexity level and risk
1
Testing
Not sure exactly what a test for this would look like, but this is clearly more correct than before.