Fix subscription manager metadata for joins #2705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the subscription manager would not update its metadata for tables that did not have a filter in a join query. This resulted in row updates not being sent to clients for those tables.
joshua-spacetime
commented
May 6, 2025
joshua-spacetime
added
the
bugfix
gefjon
approved these changes
May 6, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Should bot test before merging, but code and tests look good.
jdetter
approved these changes
May 6, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
Verified working with bot test. Results posted in the internal discord here: https://discord.com/channels/931210784011321394/1150256030433955870/1369309233979330650
joshua-spacetime
changed the title
joshua-spacetime
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jdetter
pushed a commit
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes a bug where the subscription manager would not update its metadata for tables that did not have a filter in a join query.
This resulted in row updates not being sent to clients for those tables.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing