Reduce allocations in C# when deserializing lists and arrays #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
commented
May 1, 2025
joshua-spacetime
approved these changes
May 2, 2025
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
Can you add a comment to make sure we don't revert this change in the future
rekhoff
approved these changes
May 2, 2025
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Make sense to me, save an allocation :) I see no issues with this. Approved!
|
|
kazimuth
force-pushed
the
jgilles/perf/dont-amortize
branch
from
d986f2e to
06db18d
Compare
bfops
added
release-any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Since we know the size of lists and arrays, we can allocate them up-front. This also skips allocating an
IEnumerable.API and ABI breaking changes
N/A
Expected complexity level and risk
0
Testing
Automated tests should break immediately if this is wrong