Replication Smoketest Cleanups #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap all replication tests in a class Enables use of `-k` and `-x` for individual tests as well as module - Add `--list` argument for debugging of `-k` and `-x` flags - Move docker management stuff to top-level `docker.py` - Sleep after cluster restart as workaround to wait for leader election
kim
requested review from
Centril,
bfops,
cloutiertyler,
gefjon and
jdetter
as code owners
Shubham8287
approved these changes
Apr 28, 2025
Contributor
Shubham8287
left a comment
Shubham8287
left a comment
There was a problem hiding this comment.
Thanks, Seems good.
Ran it on my another branch to test Both :)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables use of
-kand-xfor individual tests as well as module--listargument for debugging of-kand-xflagsdocker.pyOn top of #2148