Do not double compress transaction update messages #2668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If you want a hack that will also stop double-compressing subscriptions: https://github.com/clockworklabs/SpacetimeDB/compare/master...jsdt/skip-qu-compression-hack?expand=1 |
Centril
requested changes
Apr 25, 2025
Contributor
(Before merging, we should remove the |
joshua-spacetime
force-pushed
the
joshua/perf/no-double-compress-tx-updates
branch
2 times, most recently
from
4d1b0fd to
90ca090
Compare
joshua-spacetime
force-pushed
the
joshua/perf/no-double-compress-tx-updates
branch
from
edd0b35 to
2a553a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Takes compression off the hot path of subscription evaluation while we are holding the tx lock. This means the server may be doing extra work if many clients are subscribed to the same queries, but it also means that extra work will be happening on a separate thread and not blocking transactions. It also means that clients will only have to decompress messages once before deserializing them.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing