Do not double compress subscribe messages #2665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
approved these changes
Apr 23, 2025
Contributor
kazimuth
left a comment
kazimuth
left a comment
There was a problem hiding this comment.
This looks sensible. I'm satisfied that no code calling into this needs to be changed either. 👍
joshua-spacetime
deleted the
joshua/perf/no-double-compress-subscriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
There's no reason to compress the table updates within an initial subscription, because it is only being sent to a single client. The outer message will always be compressed.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing