CI - Do some basic checks that crates are publishable #2660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
2 tasks
bfops
changed the title
jdetter
reviewed
Apr 22, 2025
jdetter
approved these changes
Apr 23, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
LGTM, no objections on this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add a script that checks some basics of all the crates that we publish as part of a release:
license/license-fileanddescriptionfields are populateddev-dependenciesarepathdependenciesI also integrated it into CI.
The reason we require
pathdependencies is because it means that we can publish tocrates.iowithout having to manually editCargo.tomls to remove circular dependencies (it apparently ignores path dependencies, see rust-lang/cargo#4242).API and ABI breaking changes
None. CI-only change.
Expected complexity level and risk
2
Testing
descriptionfield from a crate causes the script to fail (https://github.com/clockworklabs/SpacetimeDB/actions/runs/14605248332/job/40972715445)pathdependencies