Do not publish RLS rules on private tables #2645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/fix/rls-on-private-tables
branch
from
fc5032d to
4d35ebb
Compare
joshua-spacetime
force-pushed
the
joshua/fix/rls-on-private-tables
branch
from
4d35ebb to
158da14
Compare
Collaborator
|
Thank you for fixing this footgun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch disallows RLS on private tables. Attempting to publish such a module will now fail.
API and ABI breaking changes
None.
This was always just a no-op since RLS doesn't doesn't apply to module owners, and non-owners cannot query private tables.
Expected complexity level and risk
1
Testing