Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Apr 18, 2025

Description of Changes

Prior to this PR, when the call to upgrade (which installs the latest version) failed, self-install would print the error and then go on to print a success message.

This PR updates the logic so that we fail if the version installation fails.

Previous behavior:

The SpacetimeDB command line tool will now be installed into /var/folders/qn/7t0vq3ts721cmgt0tgrtgzl80000gn/T/tmp.OEcKoBCvjL
Downloading latest version...
Error: failed to download and install latest SpacetimeDB version: Could not fetch release info: HTTP status client error (403 Forbidden) for url (https://api.github.com/repos/clockworklabs/SpacetimeDB/releases/latest)

The `spacetime` command has been installed as /var/folders/qn/7t0vq3ts721cmgt0tgrtgzl80000gn/T/tmp.OEcKoBCvjL/spacetime

The install process is complete; check out our quickstart guide to get started!
	<https://spacetimedb.com/docs/getting-started>

New behavior:

The SpacetimeDB command line tool will now be installed into /var/folders/qn/7t0vq3ts721cmgt0tgrtgzl80000gn/T/tmp.b0ab4mKN8T
Downloading latest version...
Error: failed to download and install latest SpacetimeDB version

Caused by:
    0: Could not fetch release info
    1: HTTP status client error (403 Forbidden) for url (https://api.github.com/repos/clockworklabs/SpacetimeDB/releases/latest)

API and ABI breaking changes

No API/ABI breaking changes.

Expected complexity level and risk

1

Testing

  • The installer now exits after saying "failed to download and install latest SpacetimeDB version", rather than continuing to a success message.

@bfops bfops requested a review from coolreader18 April 18, 2025 23:15
@bfops bfops added the release-any To be landed in any release window label Apr 21, 2025
Copy link
Collaborator

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fair. LGTM

@bfops
Copy link
Collaborator Author

bfops commented Apr 21, 2025

Okay cool, thank you!

@bfops bfops added this pull request to the merge queue Apr 21, 2025
Merged via the queue into master with commit 6ebb2ab Apr 21, 2025
15 checks passed
@bfops bfops deleted the bfops/fail-install branch July 30, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants