Use camel case for typescript unique indexes #2628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Typescript field names use camel case, but indexes were using snake case, which meant they could never find anything if the field has multiple words in it.
API and ABI breaking changes
For tables in the generated typescript code, this will change the name of the property that is generated for unique indexes. This could be considered a breaking change, but any code using those properties is already broken.
Expected complexity level and risk
1
Testing
I tested by adding a table to the quickstart app with a primary key of
entity_id, and verifying the behavior of the generated code before and after this change.