Typescript Generation: Wrap union types in parens if for arrays #2615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Apr 22, 2025
Collaborator
|
I am going to merge this because we are about to do a release that is trying to fix TypeScript codegen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When generating typescript types, if we have an array of unions, we wrap the inner type in parens, to fix #2541.
API and ABI breaking changes
This should only change the generated code in places that would have been a bug.
Expected complexity level and risk
Testing
I didn't see a good place to add full tests for the typescript generation. We will want to do that at some point.
For this change I created a module with some more complex array types and inspected the generated code.