datastore: fix two inserts in tx state with unique idx #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/issue-2601
branch
2 times, most recently
from
5b52b3d to
0a37c7d
Compare
Centril
force-pushed
the
centril/issue-2601
branch
4 times, most recently
from
97f5caf to
1389240
Compare
gefjon
requested changes
Apr 16, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Logic appears correct and tests look good. One style change that, actually, I think rises above the level of a nit, plus a couple minor requests for expanded docstrings.
Centril
force-pushed
the
centril/issue-2601
branch
from
94b631e to
85b4619
Compare
gefjon
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #2601.
This fixes two bugs, where if you:
struct T { #[unique] x: u32 }T { x: 42 }twice => bug 1, will panic but shouldn't.42=> empty iterator => bug 2API and ABI breaking changes
There was a bug where inserting twice caused a unique constraint violation, but again, it's a bug.
Expected complexity level and risk
4 - the datastore is getting messy.
Testing
test_set_semanticswas buggy and is now fixed.add_twice_and_find_issue_2601is added for bug 2.