Skip to content

Conversation

@mamcx
Copy link
Contributor

@mamcx mamcx commented Apr 14, 2025

Description of Changes

Closes #2542.

P.D: This is a temporal patch that should be replace by #2589

Expected complexity level and risk

1

Testing

  • Change spacetimedb::subscription::module_subscription_actor::tests so it checks the sql is part of the error message.

@mamcx mamcx added the release-any To be landed in any release window label Apr 14, 2025
@mamcx mamcx requested a review from joshua-spacetime April 14, 2025 18:45
@mamcx mamcx self-assigned this Apr 14, 2025
@mamcx mamcx force-pushed the mamcx/return-error-subscriptions branch 2 times, most recently from 971190f to 77596d2 Compare April 17, 2025 15:01
@mamcx mamcx force-pushed the mamcx/return-error-subscriptions branch from 77596d2 to 46e11c1 Compare April 21, 2025 15:41
Copy link
Collaborator

@joshua-spacetime joshua-spacetime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking for one more small change, but feel free to fix and merge at the same time.

@mamcx mamcx enabled auto-merge April 21, 2025 20:51
@mamcx mamcx added this pull request to the merge queue Apr 21, 2025
Merged via the queue into master with commit 4bc618f Apr 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return the query text with subscription errors

3 participants