Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Apr 11, 2025

Description of Changes

I've gotten tired of manually updating the ordered list of crates to publish, so I had chatgpt make a python script that will do it for us, given some root crates.

See how it's used in tools/publish-crates.sh.

I also made some tiny QoL improvements:

  • Extra newline in output to separate the block of output associated with each crate
  • Print which number crate we're currently on

API and ABI breaking changes

No user-facing code changes.

Expected complexity level and risk

2

Testing

The new script itself seems to work properly when I give the output a once-over. I haven't tested the new tools/publish-crates.sh using it though (for obvious reasons).

  • I tested this in the 1.1.0 release
  • Example with just the CLI crate:
$ python3 tools/find-publish-list.py --quiet --recursive cli
primitives
metrics
bindings-macro
data-structures
sats
lib
sql-parser
schema
paths
fs-utils
client-api-messages
auth
cli
  • And using it the way it's used in tools/publish-crates.sh:
$ python3 tools/find-publish-list.py --quiet --recursive cli standalone sdk bindings
primitives
metrics
bindings-macro
data-structures
sats
lib
bindings-sys
client-api-messages
sql-parser
schema
table
expr
physical-plan
execution
query
paths
fs-utils
commitlog
durability
subscription
snapshot
vm
auth
core
client-api
bindings
sdk
standalone
cli
  • The output of running it on cli standalone sdk bindings is the same length as the "static" list of crates that was in publish-crates.sh (actually it's shorter by one, because there was a duplicate crate listed)

@bfops bfops requested a review from jdetter April 16, 2025 02:45
@bfops bfops marked this pull request as ready for review April 16, 2025 02:46
@bfops bfops marked this pull request as draft April 16, 2025 02:46
@bfops bfops marked this pull request as ready for review April 16, 2025 02:53
@bfops bfops marked this pull request as draft April 16, 2025 03:44
@bfops bfops marked this pull request as ready for review April 16, 2025 05:03
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I'm glad this worked, thanks Zeke!

@bfops bfops added this pull request to the merge queue Apr 16, 2025
Merged via the queue into master with commit 9064c0b Apr 16, 2025
15 checks passed
@bfops bfops deleted the bfops/auto-deps branch July 30, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants