-
Notifications
You must be signed in to change notification settings - Fork 665
tools/publish-crates.sh - Automatically find list of dependencies
#2595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…worklabs/SpacetimeDB into bfops/auto-deps
jdetter
approved these changes
Apr 16, 2025
Collaborator
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I'm glad this worked, thanks Zeke!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I've gotten tired of manually updating the ordered list of crates to publish, so I had chatgpt make a python script that will do it for us, given some root crates.
See how it's used in
tools/publish-crates.sh.I also made some tiny QoL improvements:
API and ABI breaking changes
No user-facing code changes.
Expected complexity level and risk
2
Testing
The new script itself seems to work properly when I give the output a once-over.
I haven't tested the newtools/publish-crates.shusing it though (for obvious reasons).tools/publish-crates.sh:cli standalone sdk bindingsis the same length as the "static" list of crates that was inpublish-crates.sh(actually it's shorter by one, because there was a duplicate crate listed)