Allocate fewer vecs in eval_updates
#2567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/opt-eval-updates
branch
from
db7c4ee to
6cf7c90
Compare
Collaborator
Author
|
don't think this works anymore, but: benchmarks please |
Contributor
Criterion benchmark resultsError when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role. Caused by: |
Contributor
|
Callgrind benchmark in progress... |
1 similar comment
Contributor
|
Callgrind benchmark in progress... |
Contributor
Criterion benchmark resultsError when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role. Caused by: |
Centril
reviewed
Apr 10, 2025
Collaborator
|
This optimization makes sense, just bear in mind that we may decide to remove parallel iteration from |
Centril
reviewed
Apr 14, 2025
Centril
approved these changes
Apr 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Instead of collecting to a single vec, we collect to a linked list of vecs, which is rayon's recommended way of collecting a parallel iterator into a single data structure. This means there will be fewer allocations - for N worker threads and M query plans, it's now N vecs and N linked list nodes with standard amortizable growth, instead of M vecs that get concatenated together one at a time.
API and ABI breaking changes
Expected complexity level and risk
2 - I'm pretty confident this doesn't have a behavior change and that the changes are only optimizations, but it'd probably be worth running benchmarks to make sure
Testing