snapshot: Remote synchronization #2559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim
commented
Apr 7, 2025
gefjon
approved these changes
Apr 7, 2025
Shubham8287
approved these changes
Apr 8, 2025
kim
force-pushed
the
kim/snapshot/transfer
branch
from
b811e21 to
66092ab
Compare
This patch seeks to stabilize (for internal use) an API to synchronize a remote snapshot repository with a local one. The implementation ensures that: 1. Transferred objects are verified to match the snapshot file's hashes before being made persistent in the snapshot's object repository. 2. The snapshot file itself is written only after all objects have been stored successfully. This makes it possible for the receiving end to infer from an uncorrupted snapshot file being present that the snapshot as a whole is consistent with reasonably high confidence. In a replicated setup this is a valuable property.
kim
force-pushed
the
kim/snapshot/transfer
branch
from
66092ab to
9f3b8a5
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch seeks to stabilize (for internal use) an API to synchronize a
remote snapshot repository with a local one.
The implementation ensures that:
before being made persistent in the snapshot's object repository.
stored successfully.
This makes it possible for the receiving end to infer from an uncorrupted
snapshot file being present that the snapshot as a whole is consistent
with reasonably high confidence. In a replicated setup this is a
valuable property.
API and ABI breaking changes
Expected complexity level and risk
2
Testing