Feature gate [ClientVisibilityFilter] in C# #2556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/csharp/rls-feature-flag
branch
2 times, most recently
from
44148d0 to
6e71a5a
Compare
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
crates/bindings-csharp/Codegen/Module.cs:834
- [nitpick] Consider renaming 'rlsFeatureFlag' to a more descriptive name such as 'isClientVisibilityEnabled' to improve clarity.
var rlsFeatureFlag = context.CompilationProvider.Select((compilation, _) =>
joshua-spacetime
force-pushed
the
joshua/csharp/rls-feature-flag
branch
7 times, most recently
from
8f5b44a to
50b100e
Compare
kazimuth
approved these changes
Apr 8, 2025
Contributor
kazimuth
left a comment
kazimuth
left a comment
There was a problem hiding this comment.
Looks good, this looks like the right way to do this.
Emits a compiler warning if the STDB_UNSTABLE flag is not disabled
joshua-spacetime
force-pushed
the
joshua/csharp/rls-feature-flag
branch
from
50b100e to
c62048b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Places the
[ClientVisibilityFilter]behind theSTDB_UNSTABLEexperimental feature flag. Will emit a compiler warning unless the following is added to the module fileAPI and ABI breaking changes
None
Expected complexity level and risk
0
Testing
The build failed until I enabled
STDB_UNSTABLEin thesdk-test-csmodule.