Use Offset Index on Meta extract #2549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
force-pushed
the
shub/improve-logging
branch
2 times, most recently
from
25fb1ef to
1d25e29
Compare
Shubham8287
commented
Apr 8, 2025
Shubham8287
force-pushed
the
shub/improve-logging
branch
from
1d25e29 to
58ae3e4
Compare
kim
approved these changes
Apr 8, 2025
Shubham8287
force-pushed
the
shub/improve-logging
branch
from
c951220 to
fd25f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Metadatareset_to_internalis neither using offset index not truncating from it: fix that.API and ABI breaking changes
Expected complexity level and risk