-
Notifications
You must be signed in to change notification settings - Fork 664
Add some tokio runtime metrics. #2537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds several new metrics to monitor the Tokio runtime, providing insights into worker utilization and task scheduling.
- Added new metric definitions for various Tokio runtime parameters (worker count, blocking threads, task counts, and queue depths).
- Implemented the spawn_tokio_stats function to collect and update these metrics periodically.
- Updated the Cargo configuration to enable the tokio_unstable flag required for these metrics.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/core/src/worker_metrics/mod.rs | Introduces new Tokio runtime metrics and the stats collection task |
| .cargo/config.toml | Configures the build to use the tokio_unstable flag |
Centril
reviewed
Apr 2, 2025
Centril
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adding some tokio runtime stats. Metrics like
tokio_num_alive_tasksandtokio_global_queue_depthcould be useful to see if tokio is falling behind. Tokio metrics are described here.There are some other per-worker stats that could be useful to add in the future if we are having issues with tokio scheduling.
Many of the metrics require using the
tokio_unstablecompilation flag, which is awkward to enable. The code will still compile iftokio_unstableis not enabled, though it will have some unused variable warnings.API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
Testing
Tested by looking at metrics locally.