Skip to content

Conversation

@joshua-spacetime
Copy link
Collaborator

@joshua-spacetime joshua-spacetime commented Mar 28, 2025

Description of Changes

Incorporates RLS resolution into the sql code path - but not the subscription code path. Subscriptions will come in a separate patch.

API and ABI breaking changes

None

Expected complexity level and risk

1.5

Mostly mechanical updates.

Testing

  • Planner tests
  • Correctness tests
  • Smoke tests

@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/rls-utility branch from f9f7608 to f42afba Compare March 28, 2025 20:58
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/integrate-rls-sql branch 2 times, most recently from 61f1e2e to 300bbea Compare March 28, 2025 21:10
@joshua-spacetime joshua-spacetime linked an issue Mar 28, 2025 that may be closed by this pull request
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/rls-utility branch from f42afba to dab31e9 Compare March 31, 2025 21:06
Base automatically changed from joshua/2442/rls-utility to master March 31, 2025 23:03
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/integrate-rls-sql branch from 300bbea to ee3dee2 Compare March 31, 2025 23:23
@joshua-spacetime joshua-spacetime requested a review from mamcx April 1, 2025 05:47
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/integrate-rls-sql branch 8 times, most recently from b5d94ec to 6f08a02 Compare April 2, 2025 01:39
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/integrate-rls-sql branch from 1b51871 to bb4b374 Compare April 2, 2025 16:36
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/integrate-rls-sql branch from bb4b374 to 15dd44e Compare April 2, 2025 16:37
@joshua-spacetime joshua-spacetime changed the title Integrate view resolution into sql compilation Add rls to the sql api Apr 2, 2025
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/integrate-rls-sql branch from 15dd44e to 4567c91 Compare April 2, 2025 17:10
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Apr 2, 2025
Merged via the queue into master with commit adf4255 Apr 2, 2025
13 of 14 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/2442/integrate-rls-sql branch April 2, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RLS: Implement view expansion

5 participants