Skip to content

Conversation

@coolreader18
Copy link
Collaborator

Description of Changes

Fixes #2509, #2511.
Motivation from the latter:

Should probably just build from source. Otherwise you could get into a bad situation where a user has clockworklabs/spacetime:1.0.1 but has updated the cli inside to 1.2.0 and is confused why they're running into issues.

The dotnet install script is kinda flaky right now, see dotnet/install-scripts#582. If it's not building correctly replace https://dot.net/v1/dotnet-install.sh with https://builds.dotnet.microsoft.com/dotnet/scripts/v1/dotnet-install.sh and it should be exactly equivalent.

Expected complexity level and risk

1

Testing

  • Tested that spacetime works and cargo exists as a command.

@coolreader18 coolreader18 requested a review from jdetter March 28, 2025 02:57
@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Mar 31, 2025
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work, thanks @coolreader18 ! Tested via:

docker build -t spacetime-test .
docker run --rm -p 3000:3000 spacetime-test start

Then I logged in via

docker exec -it <name> /bin/bash

And I was able to spacetime normally, including publishing to the local server.

@coolreader18 coolreader18 added this pull request to the merge queue Apr 12, 2025
Merged via the queue into master with commit 651f79d Apr 12, 2025
17 checks passed
@coolreader18 coolreader18 deleted the noa/updateless-dockerfile branch April 15, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no runtime change This change does not affect the final binaries release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clockworklabs/spacetime docker image should not use spacetimedb-update Clean up clockworklabs/spacetime image

4 participants