Skip to content

Conversation

@joshua-spacetime
Copy link
Collaborator

@joshua-spacetime joshua-spacetime commented Mar 27, 2025

Description of Changes

This is the first of several patches that will close/implement #2442. This one in particular adds a utility for expanding or resolving RLS rules in a logical query expression, but it does not integrate it into compiler. That will happen in a follow on patch along with integration tests.

API and ABI breaking changes

None

Expected complexity level and risk

2.5

The logic is straightforward. There are a few parts that may be non-obvious like tree rotations and alpha conversion. I've tried to add ample documentation around those parts.

Testing

Integration tests will be added with in the integration patch.

@joshua-spacetime joshua-spacetime changed the title Add the main utility responsible for rls/view resolution Add the main utility responsible for rls resolution Mar 27, 2025
@joshua-spacetime joshua-spacetime requested a review from mamcx March 27, 2025 21:45
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/rls-utility branch from f9f7608 to f42afba Compare March 28, 2025 20:58
@joshua-spacetime joshua-spacetime linked an issue Mar 28, 2025 that may be closed by this pull request
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfops bfops added release-any To be landed in any release window release-1.1 backward-compatible and removed release-any To be landed in any release window labels Mar 31, 2025
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/rls-utility branch from f42afba to dab31e9 Compare March 31, 2025 21:06
@joshua-spacetime joshua-spacetime changed the title Add the main utility responsible for rls resolution Add utility for rls resolution Mar 31, 2025
@joshua-spacetime joshua-spacetime force-pushed the joshua/2442/rls-utility branch from dda1ce0 to dab31e9 Compare March 31, 2025 22:08
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Mar 31, 2025
Merged via the queue into master with commit 6d3840a Mar 31, 2025
25 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/2442/rls-utility branch March 31, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RLS: Implement view expansion

4 participants