Skip to content

Conversation

@mamcx
Copy link
Contributor

@mamcx mamcx commented Mar 20, 2025

Description of Changes

Recover the functionality on the sql cli of output Identity, ConnectionId as hex:

 bool | str                   | bytes            | identity                                                           | connection_id
------+-----------------------+------------------+--------------------------------------------------------------------+------------------------------------
 true | "This is spacetimedb" | 0x01020304050607 | 0x0000000000000000000000000000000000000000000000000000000000000000 | 0x00000000000000000000000000000000

Closes #2449.

API and ABI breaking changes

This break current output in cli, but is fixing a regression.

Expected complexity level and risk

1

Testing

  • Correct the test output_identity_connection_id so it check the same kind of output used in thecli.
  • Added Identity, ConnectionId to the sql smoke test
  • Manual inspection using the cli

@mamcx mamcx added release-any To be landed in any release window bugfix Fixes something that was expected to work differently CLI only This change only affects the CLI behavior labels Mar 20, 2025
@mamcx mamcx requested a review from joshua-spacetime March 20, 2025 16:42
@mamcx mamcx self-assigned this Mar 20, 2025
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the one file that I am a codeowner for:

crates/cli/src/subcommands/sql.rs

@mamcx mamcx force-pushed the mamcx/psql-special-types branch 2 times, most recently from f8ec644 to 47a37bf Compare March 31, 2025 16:05
Copy link
Collaborator

@joshua-spacetime joshua-spacetime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure to have a companion PR ready before merging?

@mamcx mamcx force-pushed the mamcx/psql-special-types branch 4 times, most recently from 7a4793a to 9e85c94 Compare April 2, 2025 15:59
@mamcx mamcx force-pushed the mamcx/psql-special-types branch from 9e85c94 to 62894d0 Compare April 2, 2025 16:19
@mamcx mamcx added this pull request to the merge queue Apr 2, 2025
Merged via the queue into master with commit 4ade692 Apr 2, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes something that was expected to work differently CLI only This change only affects the CLI behavior release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update formatting of timestamps and identities in PsqlFormatter

4 participants