-
Notifications
You must be signed in to change notification settings - Fork 665
Update formatting of timestamps and identities in PsqlFormatter #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
approved these changes
Mar 21, 2025
Collaborator
bfops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the one file that I am a codeowner for:
crates/cli/src/subcommands/sql.rs
f8ec644 to
47a37bf
Compare
joshua-spacetime
approved these changes
Mar 31, 2025
Collaborator
joshua-spacetime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure to have a companion PR ready before merging?
7a4793a to
9e85c94
Compare
9e85c94 to
62894d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Fixes something that was expected to work differently
CLI only
This change only affects the CLI behavior
release-any
To be landed in any release window
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Recover the functionality on the
sql cliof outputIdentity, ConnectionIdashex:Closes #2449.
API and ABI breaking changes
This break current output in
cli, but is fixing a regression.Expected complexity level and risk
1
Testing
output_identity_connection_idso it check the same kind of output used in thecli.Identity, ConnectionIdto thesqlsmoke testcli