commitlog: Fix open flags for read-only offset index #2468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, we've been opening the read-only index file with `.read(true).append(true)`. This translates to `O_RDWR | O_APPEND` on *nix, but something weird on Windows. A shared memory map requires `O_RDWR` (or equivalent) on either platform, though, meaning that we'd always fail to `mmap` the index on Windows. Open with `.read(true).write(true)` instead to fix.
kim
commented
Mar 14, 2025
Shubham8287
approved these changes
Mar 17, 2025
Contributor
Shubham8287
left a comment
Shubham8287
left a comment
There was a problem hiding this comment.
Windows is always hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, we've been opening the read-only index file with
.read(true).append(true).This translates to
O_RDWR | O_APPENDon *nix, but something weird onWindows. A shared memory map requires
O_RDWR(or equivalent) on eitherplatform, though, meaning that we'd always fail to
mmapthe index onWindows.
Open with
.read(true).write(true)instead to fix.Expected complexity level and risk
1
The impact of this bug is also small, because the offset index is not crucial
for standalone use. Who says, though, that Windows will never become a viable
server platform for SpacetimeDB?
Testing
Extends the tests to open an index using all three variants and perform lookups.