-
Notifications
You must be signed in to change notification settings - Fork 664
Print back the # of rows affected (ins, upd, del) with timings #2462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
afe71d0 to
756a8ee
Compare
bfops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the files that I am a codeowner for:
crates/cli/src/api.rs
crates/cli/src/subcommands/sql.rs
joshua-spacetime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a smoke test as well?
|
Wait, is this a breaking change? We just added a field, is that right? If it's really a breaking change, we can't release it. |
|
That's correct, this just adds a field, and so it's not a breaking change. I believe the label was added by mistake @mamcx? |
5349346 to
f4ef4b2
Compare
Yeah, I put the label before adding the |
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com>
f4ef4b2 to
067f660
Compare
Description of Changes
Closes #2430.
API and ABI breaking changes
It change the returning
jsonforsqlroute (spacetimedb::json::client_api::StmtResultJson), with added field for stats.Expected complexity level and risk
1
Testing
ins, del, updsqlcli with and without statsclioutput using the modulekeynote-benchmarks