Repair transactionality of st_client removals after disconnect
#2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
added
release-any
kim
approved these changes
Mar 12, 2025
Contributor
kim
left a comment
kim
left a comment
There was a problem hiding this comment.
I don't know what problem this fixes, really, but the change looks correct.
gefjon
requested changes
Mar 26, 2025
This was referenced Mar 26, 2025
gefjon
approved these changes
Mar 31, 2025
Centril
force-pushed
the
centril/st-client-tx
branch
from
25f87b0 to
5ec7af3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #2390 , #2505 .
API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
Not tested as of yet. To my knowledge, we don't really have the test infra to force the disconnect and then check the
TxData.