Skip to content

Conversation

@Centril
Copy link
Contributor

@Centril Centril commented Mar 11, 2025

Description of Changes

  1. Previously, we had a bug when multiple clients would subscribe to the same query and protocol (bsatn) but with different compression algorithms. This PR fixes that by memoizing once per compression algo.
  2. As part of the fix, it was also discovered that the rust sdk gzip decompression was broken. This PR fixes that too.

API and ABI breaking changes

None

Expected complexity level and risk

2

Testing

A regression test is added to confirm the bugs are fixed.

@Centril Centril requested a review from gefjon as a code owner March 11, 2025 19:13
@Centril Centril force-pushed the centril/fix-sub-multi-compression branch from 8b46104 to 9fdbb27 Compare March 11, 2025 19:17
@Centril Centril force-pushed the centril/fix-sub-multi-compression branch from 9fdbb27 to db85896 Compare March 11, 2025 19:28
@joshua-spacetime joshua-spacetime added the bugfix Fixes something that was expected to work differently label Mar 11, 2025
@Centril Centril force-pushed the centril/fix-sub-multi-compression branch from 4ae5d80 to a1264f7 Compare March 12, 2025 14:15
@Centril Centril enabled auto-merge March 12, 2025 14:15
@Centril Centril added this pull request to the merge queue Mar 12, 2025
Merged via the queue into master with commit 2ae1983 Mar 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes something that was expected to work differently release-1.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants