Implement IEquatable<Self> for all [SpacetimeDB.Type]s #2396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
added
api-break
kazimuth
changed the title
Finish generated code Update test output Codegen seems to be working, but I want to test in blackholio... Add nullable annotations Fix nullability of generated == and != More elaborate ToString Test ToString better + fix ToString for tagged enums One more test case
kazimuth
force-pushed
the
jgilles/csharp-iequatable
branch
from
1f007f1 to
f6c1a7f
Compare
Collaborator
|
I don't know the C# sdk well enough to be able to review this change sufficiently. I've reviewed the repro, and so I'm satisfied as long as it fixes the repro test, but I think @rekhoff will be able to give this a much better review. |
rekhoff
reviewed
Mar 11, 2025
Contributor
|
There is a decent amount going on here, I don't see any clear issues, and what I see makes sense. It looks like the quickstart-chat and blackholio haven't been manually tested with these changes, which would be good to do. I'm going to hold off on my approval until after I get these tested. |
rekhoff
approved these changes
Mar 11, 2025
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Reviewed code, nothing stood out as wrong. Tested the repo version Blackhol.io locally using both a Rust and C# server without running into issues. Marking this as approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes issue identified in clockworklabs/com.clockworklabs.spacetimedbsdk#264 by implementing
IEquatable<Self>for all[SpacetimeDB.Type]s in C#. Also overridesGetHashCode()andToString()for these types, which should be helpful if users want to use them as hash map keys or print them.Ready for review.
API and ABI breaking changes
Technically API breaking, since it is possible users manually implemented
IEquatablesomewhere.It's an easy fix though.
This also uses
#nullable enableand#nullable restorein the generated code. This requires a version of Unity supporting C# 8. But I believe we already required this.Expected complexity level and risk
2: this is a slightly-tricky algorithm to implement due to some pitfalls in C#'s type system.
Testing