Update PR template #2395
Merged
Update PR template #2395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
added
release-any
Collaborator
|
This seems good to me, but I think @cloutiertyler will probably want to take a look. |
Contributor
|
Oh absolutely, this has been annoying me too, but I couldn't think of a way to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This has been annoying me for months haha. This turns the instructions for each section into
<!-- comments -->, so that they don't show up in the rendered description if they're not removed, and it makes it much more obvious to see when a section isn't filled out because there's nothing there. Also removed the default X from the testing checkbox, so that the PR author has to actually check it to show they've done it. Also, maybe the "API and ABI breaking changes" should also just be a comment?Testing
Description of Changes
API and ABI breaking changes
Expected complexity level and risk
Testing