Skip to content

CLI - Fix helptext for --build-options #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bfops merged 3 commits into from
Mar 5, 2025
Merged

CLI - Fix helptext for --build-options #2349

bfops merged 3 commits into from
Mar 5, 2025

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Mar 5, 2025 •
edited
Loading

Description of Changes

We (I) changed --skip-println-checks into --lint-dir in #1928 , but didn't update this helptext.

Fixes #2347 .

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

  • Running spacetime publish --build-options='--lint-dir=' publishes without println checks

@bfops bfops mentioned this pull request Mar 5, 2025
Closed
@bfops bfops marked this pull request as ready for review March 5, 2025 17:56
@bfops bfops requested a review from cloutiertyler as a code owner March 5, 2025 17:56
@bfops bfops requested a review from jdetter March 5, 2025 18:04
@bfops bfops mentioned this pull request Mar 5, 2025
Merged
@bfops
Copy link
Collaborator Author

bfops commented Mar 5, 2025

The "Check CLI docs" job is failing because they'll be out of date once this merges.

Here's the corresponding docs PR: clockworklabs/spacetime-docs#215.

@bfops bfops changed the title CLI - Fix helptext for publish --build-options CLI - Fix helptext for --build-options Mar 5, 2025
jdetter
jdetter approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for testing 👍

@bfops bfops enabled auto-merge March 5, 2025 18:34
@bfops bfops added this pull request to the merge queue Mar 5, 2025
Merged via the queue into master with commit 6acd881 Mar 5, 2025
14 checks passed
@bfops bfops deleted the bfops/fix-helptext branch April 9, 2025 19:39
bfops added a commit that referenced this pull request Jul 17, 2025
@bfops
Update CLI docs for #2349 (#215)
cfba6bb 
* [bfops/fix-docs]: Update CLI docs for #2349

* [bfops/fix-docs]: missed one

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdetter jdetter jdetter approved these changes

@cloutiertyler cloutiertyler Awaiting requested review from cloutiertyler cloutiertyler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--build-options doesn't seem to work

3 participants

@bfops @jdetter