CI - Only tag extra docker images on tag refs #2335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fops/align-merge-script' into bfops/no-docker-branch-tags
bfops
added
release-any
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Previously, we would create an extra docker image for every git ref that was pushed. Now, we only do it for tags.
We had intended to remove the docker tags for git branches a long time ago, because it was cumbersome to map between "we're using the docker image of $BRANCH" to which exact commit was deployed. However, this
merge-docker-images.shscript slipped through the cracks, so it was still creating docker tags corresponding to git branches.API and ABI breaking changes
No code changes.
Expected complexity level and risk
1
Testing