-
Notifications
You must be signed in to change notification settings - Fork 665
Make the tools/merge-docker-images.sh script more generic
#2334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
commented
Mar 4, 2025
0b688d9 to
bd85d27
Compare
bfops
commented
Mar 4, 2025
bfops
commented
Mar 4, 2025
jdetter
approved these changes
Mar 11, 2025
Collaborator
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems useful, I saw the other PR that goes with this one and I think this change makes sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no runtime change
This change does not affect the final binaries
release-any
To be landed in any release window
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is a non-functional change to make the
tools/merge-docker-images.shscript more generic/flexible.This PR is a series of small (stacking) changes:
sanitize_docker_refset -uAPI and ABI breaking changes
This does not change code.
Expected complexity level and risk
1
Testing