Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Mar 4, 2025

Description of Changes

This is a non-functional change to make the tools/merge-docker-images.sh script more generic/flexible.

This PR is a series of small (stacking) changes:

API and ABI breaking changes

This does not change code.

Expected complexity level and risk

1

Testing

  • When I make the CI run on this branch, we successfully get all the docker tags (platform-specified, unified, and ref-tagged)

@bfops bfops requested a review from jdetter March 4, 2025 00:04
@bfops bfops marked this pull request as ready for review March 4, 2025 05:55
@bfops bfops force-pushed the bfops/align-merge-script branch from 0b688d9 to bd85d27 Compare March 4, 2025 07:11
@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Mar 4, 2025
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful, I saw the other PR that goes with this one and I think this change makes sense 👍

@bfops bfops added this pull request to the merge queue Mar 11, 2025
Merged via the queue into master with commit 644645b Mar 11, 2025
18 checks passed
@bfops bfops deleted the bfops/align-merge-script branch April 9, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no runtime change This change does not affect the final binaries release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants