set names atomic #2325
Merged
set names atomic #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@coolreader18 What can I do about the surprising and inconvenient fact that |
Collaborator
|
|
1 task
cloutiertyler
approved these changes
Feb 28, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
This looks great to me, thanks for cleaning it up!
coolreader18
approved these changes
Feb 28, 2025
Collaborator
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
Contributor
Author
|
Thanks @coolreader18! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks #2317 to perform the replacement of domain names as an atomic operation.
Testing
Adds two smoketest asserting that the endpoint works and that the caller must be the owner of the database.