Removed the EULA check in the CLI #2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
requested review from
coolreader18 and
jdetter
and removed request for
coolreader18
jdetter
approved these changes
Feb 26, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I have not tested this either but I agree this looks trivial
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
coolreader18
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As discussed internally, a EULA is not necessary given our existing BuSL and Apache 2.0 licenses.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
I have not tested it, but it is absolutely trivial.