Skip to content

Conversation

@coolreader18
Copy link
Collaborator

@coolreader18 coolreader18 commented Feb 26, 2025

Description of Changes

This just curls & runs the install script on a blank image. Technically won't work until the new script is up on the website.

Expected complexity level and risk

1

Testing

I've tested a little bit and will test more once this is merged and I can download the artifacts built from CI (my system has too new a glibc version 😢 )

@gefjon
Copy link
Contributor

gefjon commented Feb 26, 2025

I would expect that we want to have other things also present inside this docker. E.g.:

  • Rustup, cargo, rustc, the wasm32-unknown-unknown target, and everything else one needs to compile and publish a Rust module.
  • Dotnet, the dotnet WASI SDK, and whatever else one needs to compile and publish a C# module.
  • wasm-opt.

Testing I would expect to be done:

  • One can spacetime start using the docker and connect an external client (e.g. a web browser) to the running host.
  • One can bind-mount a module project directory into the docker and then spacetime publish it, both locally and to a remote host.
  • One can use spacetime call and spacetime sql from the docker, both locally and to a remote host.

~~Bonus points:

  • One can bind-mount a Rust, C# or TypeScript client project directory into the docker and then compile and run it, connecting to either a local or a remote host.~~

Nope. We're sticking to having this be for module-side dev and whatnot. People building clients can do so on their own.

@coolreader18 coolreader18 linked an issue Feb 26, 2025 that may be closed by this pull request
@coolreader18 coolreader18 force-pushed the noa/dockerfile branch 2 times, most recently from 834ff09 to 028d82c Compare February 27, 2025 19:52
@coolreader18
Copy link
Collaborator Author

I'll test this further once this is merged and I can download the artifacts built from CI on master (my system has too new a glibc version 😢)

@coolreader18 coolreader18 added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit 956b4f8 Feb 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create separate docker container image for spacetime install page

3 participants