Handle optimization and execution errors on initial subscription #2213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
reviewed
Feb 6, 2025
Compiles a subscription once and caches the plan for reuse. This removes superfluous error checks during subscription update.
joshua-spacetime
force-pushed
the
joshua/sub-error-handling
branch
from
9a780bb to
75ca5a4
Compare
joshua-spacetime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
If an error occurs during query optimization or execution of the initial subscription, we return that error to the client.
This patch also simplifies the subscription compilation code, particularly join subscriptions.
It also compiles a subscription once and caches the plan for reuse, as was the case for the previous subscription api. This removes superfluous error checks during subscription update.
API and ABI breaking changes
None
Expected complexity level and risk
3
Updates some type signatures that permeate the codebase, but we also have a lot of test coverage over this part of the code.
Testing
This is a refactor. All previous tests apply.