add direct indices, except for in datastore & C#
#2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
reviewed
Feb 4, 2025
Contributor
kazimuth
left a comment
kazimuth
left a comment
There was a problem hiding this comment.
All the schema stuff looks good.
coolreader18
approved these changes
Feb 4, 2025
Collaborator
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
macro/bindings stuff generally LGTM; UniqueColumn will probably need an extra bound in the future in order to tell it whether to use btree or direct, but that's fine.
Centril
force-pushed
the
centril/direct-index
branch
from
086b62f to
70bdde4
Compare
Centril
force-pushed
the
centril/direct-index
branch
from
ef7ddf6 to
5aae1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds the schema and rust module side support for
directindices.What remains to be done after this PR is to:
API and ABI breaking changes
None
Expected complexity level and risk
3, touches a lot of places.
Testing
Some new tests are added for the schema and existing tests are amended.