Fix sending of subscription errors. #2166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Jan 23, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
I approved these in the original PR; I'll approve em here too.
bfops
pushed a commit
that referenced
this pull request
Jan 23, 2025
bfops
pushed a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is pulling out the server side changes that were originally in #2111.
Previously the code was not sending subscription errors for invalid queries (because we were treating those errors as generic internal errors). This fixes that. It also adds the query id to those subscription error messages, so that the clients aren't forced to track the request ids.
Expected complexity level and risk
1
Testing
This change is covered with some end-to-end tests in #2111.
Adding unit tests in the future would be good.