Run smoketests on windows in ci #2129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
changed the title
coolreader18
force-pushed
the
noa/windows-ci
branch
17 times, most recently
from
f4f5bae to
d1fbc4e
Compare
coolreader18
force-pushed
the
noa/windows-ci
branch
from
d1fbc4e to
3b2d466
Compare
bfops
reviewed
Jan 16, 2025
bfops
reviewed
Jan 16, 2025
bfops
reviewed
Jan 16, 2025
bfops
reviewed
Jan 16, 2025
bfops
reviewed
Jan 16, 2025
bfops
reviewed
Jan 16, 2025
bfops
reviewed
Jan 16, 2025
bfops
reviewed
Jan 16, 2025
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
Looks pretty great to me 💯 I commented on a few small things.
bfops
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I don't intend to spend a ton of time on this, but maybe it'll just workyay :)Only some slight modifications to the smoketest code needed to get this working, and then wrestling with dotnet-sdk in the ci environment. For now this is running on GitHub's windows-latest runner, but we could switch to a self-hosted runner at some point if we wanted to.
Expected complexity level and risk
1
Testing
That's what we're doing here :)