Make the key of Table.indexes be IndexId
#2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/index-key-by-id
branch
from
55abea9 to
2a9eed3
Compare
Centril
force-pushed
the
centril/index-key-by-id
branch
from
2a9eed3 to
77fc966
Compare
gefjon
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
By making
Table.indexeskeyed overIndexIdinstead ofColList, this reduces the number of map lookups with the new query engine, as well as theIndexIdbased module ABIs. There are some remaining uses ofColListbased index searches, but these are typically not hot, and can be further simplified in the future.The main motivation beyond the above is also to facilitate the implementation of the update ABI.
API and ABI breaking changes
None
Expected complexity level and risk
3 -- this is local to the datastore, but there are some transactionality interactions to review.
Testing
Existing tests are updated to fit the new regime.