query rewriter #2031
Merged
query rewriter #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Dec 3, 2024
mamcx
reviewed
Dec 3, 2024
mamcx
reviewed
Dec 3, 2024
Contributor
mamcx
left a comment
mamcx
left a comment
There was a problem hiding this comment.
Looks good, just fix the test...
joshua-spacetime
force-pushed
the
joshua/perf/rewrite
branch
2 times, most recently
from
bb9dee9 to
3c53826
Compare
mamcx
approved these changes
Dec 5, 2024
Contributor
mamcx
left a comment
mamcx
left a comment
There was a problem hiding this comment.
LGTM. The comments will be in another pr as discussed...
Centril
reviewed
Dec 6, 2024
joshua-spacetime
force-pushed
the
joshua/perf/rewrite
branch
4 times, most recently
from
cb054eb to
caec982
Compare
joshua-spacetime
force-pushed
the
joshua/perf/rewrite
branch
from
caec982 to
fc4d730
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of query rewrite rules optimizing index joins