Decide that BSATN byte that ain't 0 or 1 is not a valid AV::Bool
#2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Nov 29, 2024
Centril
force-pushed
the
centril/bool-is-0-or-1
branch
from
2efc4ee to
c61b59e
Compare
Centril
force-pushed
the
centril/bool-is-0-or-1
branch
from
c61b59e to
0a06a91
Compare
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Just also saying that I approve of this. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
API and ABI breaking changes
Yes, this no longer accepts e.g.,
2astrue.Testing
A proptest is added to ensure this new (correct) behavior does not regress.