commitlog: Fix set_epoch #2005
Merged
commitlog: Fix set_epoch #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cmp` arguments were flipped, sabotaging the intent. Add some tests while we're at it. Also make sure the `spacetimedb-paths` crate selects the features it needs, so that we don't need to rely on workspace feature unification to be able to run said tests.
Shubham8287
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cmparguments were flipped, sabotaging the intent. Add some tests while we're at it.Also make sure the
spacetimedb-pathscrate selects the features it needs, so that we don't need to rely on workspace feature unification to be able to run said tests.