Clean up auth related code with traits, and reuse existing key generation code. #1988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is an attempt to clean up auth-related code. To summarize the main changes:
NodeDelegatetrait were removed, and the functionality was put in theJwtAuthProvidertrait.NodeDelegatenow just has one function to return an auth provider. This should make it easier to change this in the future. The new trait also exposes functions for signing and verifying keys, rather than giving the concrete keys.SpacetimeIdentityClaims2is now the onlySpacetimeIdentityClaims.jsonwebkeyin the token validation tests, we use the same key generate code that is used for standalone key generation. There were some small changes to the key generate code to make it easier to reuse.There is a corresponding private PR.
API and ABI breaking changes
None.
Expected complexity level and risk
Testing
Most of the unit tests for this code are in
token_validation.rs.