Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Nov 6, 2024

Description of Changes

Currently, spacetime login just silently returns if the user is already logged in.

This PR adds a message informing the user that they are already logged in.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

  • When I run spacetime login, I see the message.
$ cargo run -- login
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.27s
     Running `target/debug/spacetime login`
You are already logged in.
If you want to log out, use spacetime logout.

@bfops bfops marked this pull request as ready for review November 8, 2024 18:43
@bfops bfops requested a review from cloutiertyler as a code owner November 8, 2024 18:43
@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels Nov 8, 2024
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@bfops bfops added this pull request to the merge queue Nov 9, 2024
Merged via the queue into master with commit fdb1a71 Nov 9, 2024
@bfops bfops deleted the bfops/login-note branch April 9, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI only This change only affects the CLI behavior release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants